On Thu, Mar 16, 2023 at 08:13:25AM +0100, Markus Armbruster wrote: > The C code generator fails to honor 'if' conditions of command and > event arguments. > ... > > Conditional arguments work fine with 'boxed': true, simply because > complex types with conditional members work fine. Not worth breaking. > > Reject conditional arguments unless boxed.
Yay - matches my earlier suggestion at how to avoid #if in the middle of a parameter list. > > Move the tests cases covering unboxed conditional arguments out of > tests/qapi-schema/qapi-schema-test.json. Cover boxed conditional > arguments there instead. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- A big end to the series, but I'm glad we got here. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
