On 3/7/23 02:17, Peter Maydell wrote:
It looks like we (inadvertently) broke "-R 0 means turn off"
in 2019 with commit dc18baaef36d95e5; prior to that the
64-on-32 default was set by the initial value of the global
variable and could be overridden on the command line. After
that we ended up doing the default-value stuff after the
command line was parsed instead.
(Not 64-on-32, but 32-on-64.)
I don't understand how 32-on-64 would ever work without reserved_va. The host kernel
would otherwise place mmap blocks anywhere it chooses, which may not be within 4GB of any
given guest_base.
I would not characterize that patch as "inadvertently broke" but "fixed bug but didn't
record that fact in the commit message".
r~
