Thomas Huth <th...@redhat.com> writes: > On 22/03/2023 10.28, Daniel P. Berrangé wrote: >> On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote: >>> Il lun 20 mar 2023, 16:42 Thomas Huth <th...@redhat.com> ha scritto: >>> >>>> Would it make sense to add it e.g. to "-action" instead, i.e. something >>>> like >>>> "-action teardown=async" ? >>>> >>> >>> -action is just a wrapper for the action-set QMP command. I don't think it >>> fits very well; its arguments are only guest actions while asynchronous >>> tear down happens for example when you issue a quit command on the monitor. >> Right, we discussed -action when this feature was first proposed and >> that was the reason it was discounted. > > I guess that was this thread here : > > https://mail.gnu.org/archive/html/qemu-devel/2022-08/msg04479.html > > ? > > Anyway, how to continue now here? If I've got that right, we currently need > an option that takes a parameter if we want to make it visible via QAPI, > right?
Visible in query-command-line-options, to be precise. To make it visible in query-qmp-schema, you need to make it a QMP command in addition to a CLI option. Would that be possible? > So maybe remove the previous option (since it cannot be used by upper layer > like libvirt anyway yet), and introduce a new one like "-teardown async|sync" > ? Or rework the current one into "-async-teardown on|off" (similar to > "-sandbox on")? Any preferences? > > Or do we want something even more generic instead, e.g.: > > -run-with teardown=async > -run-with daemonized=on > -run-with chroot=/path/to/chroot/dir > -run-with userid=UID > > ... so we could get rid of -deamonize, -chroot and -runas and other similar > options one day? If we expect more teardown-relation configuration knobs, then something like -teardown async=[on|off] would let us add more with ease. -run-with is a bit of a grab bag. We've done worse :)