On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: > This is a preparational patch for the next one to make the following > more obvious: > > First, pci_bus_irqs() is now called twice in case of Xen where the > second call overrides the pci_set_irq_fn with the Xen variant.
pci_bus_irqs() does allocates pci_bus->irq_count, so the second call in piix3_xen_realize() will leak `pci_bus->irq_count`. Could you look if pci_bus_irqs_cleanup() can be called before the second pci_bus_irqs() call, or maybe some other way to avoid the leak? > Second, pci_bus_set_route_irq_fn() is now also called in Xen mode. > > Signed-off-by: Bernhard Beschow <shen...@gmail.com> > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> Beside the leak which I think can happen only once, patch is fine: Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> Thanks, -- Anthony PERARD