On Thu, Mar 30, 2023 at 11:20:11AM -0500, Corey Minyard wrote: > I almost never say this, as patches are usually too large :), but it > would be nice if you combined this with the patch that uses the > structure so we can see what it's used for. Especially since that patch > is several patches down the line.
Actually, in re-reviewing, I don't see this used at all. Is there something I'm missing? > > -corey > > On Wed, Mar 22, 2023 at 05:55:10PM +0000, Titus Rwantare wrote: > > Reviewed-by: Hao Wu <wuhao...@google.com> > > Signed-off-by: Titus Rwantare <tit...@google.com> > > --- > > include/hw/i2c/pmbus_device.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h > > index 7dc00cc4d9..2e95164aa1 100644 > > --- a/include/hw/i2c/pmbus_device.h > > +++ b/include/hw/i2c/pmbus_device.h > > @@ -444,6 +444,14 @@ typedef struct PMBusCoefficients { > > int32_t R; /* exponent */ > > } PMBusCoefficients; > > > > +/** > > + * VOUT_Mode bit fields > > + */ > > +typedef struct PMBusVoutMode { > > + uint8_t mode:3; > > + int8_t exp:5; > > +} PMBusVoutMode; > > + > > /** > > * Convert sensor values to direct mode format > > * > > -- > > 2.40.0.rc1.284.g88254d51c5-goog > >