On Tue, 4 Apr 2023 at 19:25, David Woodhouse <dw...@infradead.org> wrote:
>
> From: David Woodhouse <d...@amazon.co.uk>
>
> There was a superfluous allocation of the XS handle, leading to it
> being leaked on both the error path and the success path (where it gets
> allocated again).
>
> Spotted by Coverity (CID 1508098).
>
> Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to
> internal emulation")
> Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: David Woodhouse <d...@amazon.co.uk>
> ---
> hw/xen/xen-operations.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen-operations.c b/hw/xen/xen-operations.c
> index 4b78fbf4bd..3d213d28df 100644
> --- a/hw/xen/xen-operations.c
> +++ b/hw/xen/xen-operations.c
> @@ -287,7 +287,7 @@ static void watch_event(void *opaque)
> static struct qemu_xs_handle *libxenstore_open(void)
> {
> struct xs_handle *xsh = xs_open(0);
> - struct qemu_xs_handle *h = g_new0(struct qemu_xs_handle, 1);
> + struct qemu_xs_handle *h;
>
> if (!xsh) {
> return NULL;
> --
> 2.34.1
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
