On Wed, 5 Apr 2023 04:47:48 -0400
"Michael S. Tsirkin" <m...@redhat.com> wrote:
[...]
> This is arguably a regression but not in this release yes?
> So I don't think it needs to block qemu release.
yep, it's 'old' regression introduced in earlier releases
> Fixes: cce8944cc9ef ("qdev-monitor: Forbid repeated device_del")
>
>
> > ---
> > v2:
> > * change timeout to 1ms
> > * add comment to expire usage
> > * massage commit message to be a bit more clear
> >
> > CC: m...@redhat.com
> > CC: anisi...@redhat.com
> > CC: jus...@redhat.com
> > CC: kra...@redhat.com
>
> It's helpful to have CC before --- so backporters know whom to CC, too.
>
> > ---
> > hw/acpi/pcihp.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> > index dcfb779a7a..5daa732a33 100644
> > --- a/hw/acpi/pcihp.c
> > +++ b/hw/acpi/pcihp.c
> > @@ -357,6 +357,16 @@ void
> > acpi_pcihp_device_unplug_request_cb(HotplugHandler *hotplug_dev,
> > * acpi_pcihp_eject_slot() when the operation is completed.
> > */
> > pdev->qdev.pending_deleted_event = true;
> > + /* if unplug was requested before OSPM is initialized,
> > + * linux kernel will clear GPE0.sts[] bits during boot, which
> > effectively
> > + * hides unplug event. BAnd than followup qmp_device_del() calls
> > remain
>
> BAnd?
>
> > + * blocked by above flag permanently.
> > + * Unblock qmp_device_del() by setting expire limit, so user can
> > + * repeat unplug request later when OSPM has been booted.
> > + */
> > + pdev->qdev.pending_deleted_expires_ms =
> > + qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL); /* 1 msec */
> > +
> > s->acpi_pcihp_pci_status[bsel].down |= (1U << slot);
> > acpi_send_event(DEVICE(hotplug_dev), ACPI_PCI_HOTPLUG_STATUS);
> > }
> > --
> > 2.39.1
>
