This series is yet another attempt to clean up the PCI IDE models. It is mainly inspired the Mark's invaluable input from previous discussions. In particular, this series attempts to follow the "PCI IDE controller specification" closer. As a side effect, it also resolves usage of the isabus global in PIIX. Last but not least it fixes the VIA IDE controller to not depend on its south bridge which fixes a circular dependency.
The series is structured as follows: The first three commits resolve a circular dependency between the VIA IDE controller and its south bridge, thereby implementing legacy PCI IDE interrupt routing which was missing so far. The next five patches factor out common code into the PCI IDE base class. The next two patches resolve usage of the isabus global in PIIX by reusing now common code from the base class. The same is then done for the SIL3112 controller. Finally, a small convenience function is introduced which should hide some implementation details in the PCI IDE base class. Testing done: * `make check` * `make check-avocado` * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device \ ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel morphos-3.17/boot.img` The machine booted successfully and a startup sound was hearable * `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device \ ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel morphos-3.17/boot.img` The machine booted successfully and applications could be started. * qemu-system-x86_64 was used for hours during work Bernhard Beschow (13): hw/ide/pci: Expose legacy interrupts as GPIOs hw/ide/via: Implement ISA IRQ routing hw/isa/vt82c686: Remove via_isa_set_irq() hw/ide: Extract IDEBus assignment into bmdma_init() hw/ide: Extract pci_ide_class_init() hw/ide: Extract bmdma_init_ops() hw/ide: Extract pci_ide_{cmd,data}_le_ops initialization into base class constructor hw/ide: Rename PCIIDEState::*_bar attributes hw/ide/piix: Disuse isa_get_irq() hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops hw/ide/sii3112: Reuse PCIIDEState::{cmd,data}_ops hw/ide/sii3112: Reuse PCIIDEState::bmdma_ops hw/ide: Extract bmdma_clear_status() include/hw/ide/pci.h | 12 ++- include/hw/isa/vt82c686.h | 2 - hw/ide/cmd646.c | 59 ++------------- hw/ide/pci.c | 73 ++++++++++++++++++- hw/ide/piix.c | 88 ++++++++-------------- hw/ide/sii3112.c | 150 +++++++++++++++++++------------------- hw/ide/via.c | 64 +++------------- hw/isa/vt82c686.c | 23 ++++-- hw/ide/trace-events | 7 +- 9 files changed, 221 insertions(+), 257 deletions(-) -- 2.40.0