On 22/4/23 17:07, Bernhard Beschow wrote:
There are three private copies of bmdma_setup_bar() with small adaptions.
Consolidate them into one public implementation.

While at it rename the function to bmdma_init_ops() to reflect that the memory
regions being initialized represent BMDMA operations. The actual mapping as a
PCI BAR is still performed separately in each device.

Note that the bmdma_bar attribute will be renamed in a separate commit.

Signed-off-by: Bernhard Beschow <shen...@gmail.com>
---
  include/hw/ide/pci.h |  1 +
  hw/ide/cmd646.c      | 20 +-------------------
  hw/ide/pci.c         | 16 ++++++++++++++++
  hw/ide/piix.c        | 19 +------------------
  hw/ide/via.c         | 19 +------------------
  5 files changed, 20 insertions(+), 55 deletions(-)

Nice.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to