On 02/01/2012 11:21 PM, Andreas Färber wrote:

+static const VMStateDescription VMState_Exynos4210IRQGate = {
Not CamelCase ;)

But seriously, I really think review makes more sense when the patches
can actually be applied unmodified.
Out patches could be applied to current master without modification ;)
  Since Peter, as I understood, does
not have a kernel to test these machines himself,
Anyone can get the kernel from kernel.org. It works with default configuration
as mentioned in the cover letter.
  this will need to be
rebased by you guys - either onto Anthony's designated qom-upstream.X
branch or wait til next week for the patches to arrive in master.

Regards,
Andreas

Thanks for the remarks. It seems that our patches will not be applied until
Anthony's patches come to upstream. If so, we will fix CamelCases and spaces, rebase and
produce v12.
Could someone, please, advise a better/faster way: wait until Anthony's patches are landed into master or rebase on his branch? I'm afraid that till these patches are not in the master we could have to rebase many times if qom-upstream.X branch is used because we
do not actually know which version will be last.

--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevo...@samsung.com



Reply via email to