> -----Original Message-----
> From: Paolo Bonzini <pbonz...@redhat.com>
> Sent: Thursday, April 27, 2023 7:57 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimp...@quicinc.com>
> Subject: [PATCH] target/hexagon: fix = vs. == mishap
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> Coverity reports a parameter that is "set but never used". This is caused by
> an assignment operator being used instead of equality.
>
> Cc: Taylor Simpson <tsimp...@quicinc.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> target/hexagon/idef-parser/parser-helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/hexagon/idef-parser/parser-helpers.c
> b/target/hexagon/idef-parser/parser-helpers.c
> index 86511efb62b9..0a01ec39b75e 100644
> --- a/target/hexagon/idef-parser/parser-helpers.c
> +++ b/target/hexagon/idef-parser/parser-helpers.c
> @@ -1123,7 +1123,7 @@ HexValue gen_extend_op(Context *c,
> HexValue *value,
> HexSignedness signedness) {
> - unsigned bit_width = (dst_width = 64) ? 64 : 32;
> + unsigned bit_width = (dst_width == 64) ? 64 : 32;
> HexValue value_m = *value;
> HexValue src_width_m = *src_width;
Cc: Alessandro Di Federico <a...@rev.ng>
Cc: Anton Johansson <a...@rev.ng>
Reviewed-by: Taylor Simpson <tsimp...@quicinc.com>
