On 5/3/23 11:12, Alex Bennée wrote:
From: Fabiano Rosas <faro...@suse.de>

This machine hardcodes initialization of the USB device, so select the
corresponding Kconfig. It is not enough to have it as "default y if
XLNX_VERSAL" at usb/Kconfig because building --without-default-devices
disables the default selection resulting in:

$ ./qemu-system-aarch64 -M xlnx-zcu102
qemu-system-aarch64: missing object type 'usb_dwc3'
Aborted (core dumped)

Signed-off-by: Fabiano Rosas <faro...@suse.de>
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Message-Id: <20230208192654.8854-8-faro...@suse.de>
---
  hw/arm/Kconfig | 1 +
  hw/usb/Kconfig | 1 -
  2 files changed, 1 insertion(+), 1 deletion(-)

This one is correct: "-M xlnx-zcu102 -nodefaults" has a usb_dwc3 device.

Acked-by: Paolo Bonzini <pbonz...@redhat.com>

Paolo

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 168c1e8089..cec7898bb7 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -439,6 +439,7 @@ config XLNX_VERSAL
      select OR_IRQ
      select XLNX_BBRAM
      select XLNX_EFUSE_VERSAL
+    select XLNX_USB_SUBSYS
config NPCM7XX
      bool
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index ce4f433976..0ec6def4b8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -136,5 +136,4 @@ config USB_DWC3
config XLNX_USB_SUBSYS
      bool
-    default y if XLNX_VERSAL
      select USB_DWC3


Reply via email to