Hi On Fri, May 5, 2023 at 3:43 PM Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Fri, May 05, 2023 at 03:39:47PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Dorinda Bassey <dbas...@redhat.com> > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > > both an audio sink and source. This backend is available on most systems > > > > Add Pipewire entry points for QEMU Pipewire audio backend > > Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() > > qpw_write function returns the current state of the stream to pwaudio > > and Writes some data to the server for playback streams using pipewire > > spa_ringbuffer implementation. > > qpw_read function returns the current state of the stream to pwaudio and > > reads some data from the server for capture streams using pipewire > > spa_ringbuffer implementation. These functions qpw_write and qpw_read > > are called during playback and capture. > > Added some functions that convert pw audio formats to QEMU audio format > > and vice versa which would be needed in the pipewire audio sink and > > source functions qpw_init_in() & qpw_init_out(). > > These methods that implement playback and recording will create streams > > for playback and capture that will start processing and will result in > > the on_process callbacks to be called. > > Built a connection to the Pipewire sound system server in the > > qpw_audio_init() method. > > > > Signed-off-by: Dorinda Bassey <dbas...@redhat.com> > > Reviewed-by: Volker Rümelin <vr_q...@t-online.de> > > Message-Id: <20230417105654.32328-1-dbas...@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > meson.build | 8 + > > qapi/audio.json | 44 ++ > > audio/audio_template.h | 4 + > > audio/audio.c | 3 + > > audio/pwaudio.c | 915 ++++++++++++++++++++++++++++++++++ > > audio/meson.build | 1 + > > audio/trace-events | 8 + > > meson_options.txt | 4 +- > > qemu-options.hx | 21 + > > scripts/meson-buildoptions.sh | 8 +- > > 10 files changed, 1013 insertions(+), 3 deletions(-) > > create mode 100644 audio/pwaudio.c > > This doesn't add pipewire dev packages to the dockerfiles, so none of > this will get built during CI unless something else we have happens to > be pulling in pipewire dev packages indirectly. > > I was working on it, and further cleanups, but they can be added on top to avoid having to ask Dorinda and spread the work. -- Marc-André Lureau
