> -----Original Message-----
> From: Taylor Simpson <[email protected]>
> Sent: Tuesday, May 9, 2023 2:28 PM
> To: Marco Liebel (QUIC) <[email protected]>; qemu-
> [email protected]
> Cc: Brian Cain <[email protected]>; Matheus Bernardino (QUIC)
> <[email protected]>
> Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests
> 
> 
> 
> > -----Original Message-----
> > From: Marco Liebel (QUIC) <[email protected]>
> > Sent: Tuesday, May 9, 2023 1:43 PM
> > To: [email protected]
> > Cc: Taylor Simpson <[email protected]>; Brian Cain
> > <[email protected]>; Matheus Bernardino (QUIC)
> > <[email protected]>; Marco Liebel (QUIC)
> > <[email protected]>
> > Subject: [PATCH] Remove test_vshuff from hvx_misc tests
> >
> > test_vshuff checks that the vshuff instruction works correctly when both
> > vector registers are the same. Using vshuff in this way is undefined and 
> > will
> > be rejected by the compiler in a future version of the toolchain.
> >
> > Signed-off-by: Marco Liebel <[email protected]>
> > ---
> >  tests/tcg/hexagon/hvx_misc.c | 45 ------------------------------------
> >  1 file changed, 45 deletions(-)
> 
> Let's not remove the test completely.  Just change it to use different 
> registers.

I'm fine either way.  But IIRC we added this test particularly in order to 
verify the potentially ambiguous behavior of the same operand here.  It may be 
well tested otherwise.

Reply via email to