Re: [Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one

[Anthony Liguori]

On 02/04/2012 02:02 AM, Paolo Bonzini wrote:

Integer properties did not work.

Signed-off-by: Paolo Bonzini<pbonz...@redhat.com>

Reviewed-by: Anthony Liguori <aligu...@us.ibm.com>

Regards,

Anthony Liguori

---
  hw/qdev-properties.c |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index d69a987..debb37f 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque,
          error_propagate(errp, local_err);
          return;
      }
-    if (value>  prop->info->min&&  value<= prop->info->max) {
+    if (value>= prop->info->min&&  value<= prop->info->max) {
          *ptr = value;
      } else {
          error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
@@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque,
          error_propagate(errp, local_err);
          return;
      }
-    if (value>  prop->info->min&&  value<= prop->info->max) {
+    if (value>= prop->info->min&&  value<= prop->info->max) {
          *ptr = value;
      } else {
          error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
@@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque,
          error_propagate(errp, local_err);
          return;
      }
-    if (value>  prop->info->min&&  value<= prop->info->max) {
+    if (value>= prop->info->min&&  value<= prop->info->max) {
          *ptr = value;
      } else {
          error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,