On Thu, May 11, 2023 at 09:10:14PM -0500, Eric Blake wrote: > v1 was here: > https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg01988.html > > since then: > - make parse_uint easier to use, then use it in qemu_strtosz > - add even more unit tests > - fix a bug in qemu_strtoui > - avoid dereferencing randome memory during unit tests [Hanna] > - other cleanups as I found them > - compress the strtosz unit tests (the major cause of the large > interdiff statistics) > > backport-diff looks like: > > 001/19:[----] [--] 'test-cutils: Avoid g_assert in unit tests' > 002/19:[----] [--] 'test-cutils: Use g_assert_cmpuint where appropriate' > 003/19:[----] [--] 'test-cutils: Test integral qemu_strto* value on failures' > 004/19:[down] 'test-cutils: Test more integer corner cases' > 005/19:[down] 'cutils: Fix wraparound parsing in qemu_strtoui' > 006/19:[down] 'cutils: Document differences between parse_uint and > qemu_strtou64' > 007/19:[down] 'cutils: Adjust signature of parse_uint[_full]' > 008/19:[down] 'cutils: Allow NULL endptr in parse_uint()' > 009/19:[0147] [FC] 'test-cutils: Add coverage of qemu_strtod' > 010/19:[----] [--] 'test-cutils: Prepare for upcoming semantic change in > qemu_strtosz' > 011/19:[down] 'test-cutils: Refactor qemu_strtosz tests for less boilerplate' > 012/19:[down] 'cutils: Allow NULL str in qemu_strtosz' > 013/19:[----] [--] 'numa: Check for qemu_strtosz_MiB error' > 014/19:[down] 'test-cutils: Add more coverage to > qemu_strtosz11;rgb:1e1e/1e1e/1e1e'
Not sure how I managed to corrupt that subject line while rebasing (looks like a read race on /dev/tty where my editor intercepted bytes intended to go to the shell's terminal); a corrected version is now available at: git fetch https://repo.or.cz/qemu/ericb.git strtosz https://repo.or.cz/qemu/ericb.git/tree/refs/heads/strtosz and with that fixed, this line changes to: 014/18:[0335] [FC] 'test-cutils: Add more coverage to qemu_strtosz' > 015/19:[0178] [FC] 'cutils: Set value in all qemu_strtosz* error paths' > 016/19:[----] [--] 'cutils: Set value in all integral qemu_strto* error paths' > 017/19:[down] 'cutils: Use parse_uint in qemu_strtosz for negative rejection' > 018/19:[0018] [FC] 'cutils: Improve qemu_strtod* error paths' > 019/19:[0107] [FC] 'cutils: Improve qemu_strtosz handling of fractions' > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
