On Tue, May 16, 2023 at 6:01 PM Igor Mammedov <imamm...@redhat.com> wrote: > > On Mon, 15 May 2023 16:33:10 -0400 > Eric DeVolder <eric.devol...@oracle.com> wrote: > > > Currently i386 QEMU generates MADT revision 3, and reports > > MADT revision 1. Set .revision to 3 to match reality. > > > > Link: > > https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora > > cle.com/T/#t > > Signed-off-by: Eric DeVolder <eric.devol...@oracle.com> > > --- > > hw/i386/acpi-common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/i386/acpi-common.c b/hw/i386/acpi-common.c > > index 52e5c1439a..8a0932fe84 100644 > > --- a/hw/i386/acpi-common.c > > +++ b/hw/i386/acpi-common.c > > @@ -102,7 +102,7 @@ void acpi_build_madt(GArray *table_data, BIOSLinker > > *linker, > > MachineClass *mc = MACHINE_GET_CLASS(x86ms); > > const CPUArchIdList *apic_ids = > > mc->possible_cpu_arch_ids(MACHINE(x86ms)); > > AcpiDeviceIfClass *adevc = ACPI_DEVICE_IF_GET_CLASS(adev); > > - AcpiTable table = { .sig = "APIC", .rev = 1, .oem_id = oem_id, > > + AcpiTable table = { .sig = "APIC", .rev = 3, .oem_id = oem_id, > > .oem_table_id = oem_table_id }; > > > > acpi_table_begin(&table, table_data); > > make check fails for me at this point > (my guess is that not all APIC tables are whitelisted)
I think the patchset needs to be rebased and the blobs regenerated.
