Hi Peter, Anthony suggested to us the Idea of setting up bootloaders as devices in order to solve this command line argument problem. I have posted a patch to the mailing list ([RFC PATCH] arm boot: added QOM device definition) which is my first attempt at this for arm_boot, i.e. arm_boot.c is now a device model and boot command line arguments (e.g. like the new dtb argument this series introduces) can be added as device model properties without requiring a change pattern to vl.c and friends. Could I get a review of that in the context of what you are trying to do with command line arguments here?
Regards, Peter On Wed, Feb 8, 2012 at 3:41 PM, Peter Maydell <peter.mayd...@linaro.org>wrote: > This patch series is basically Grant's v2 "arm: add device tree support" > patch (http://patchwork.ozlabs.org/patch/138883/) rearranged to use > qemu -machine options rather than a global to pass through the device > tree blob filename. This is based on a suggestion by Anthony in IRC; > I'm a bit sceptical myself, but anyway here's the code... > > Patches 1 and 2 are pure bugfixes to the existing -machine handling > and should be applied anyway IMHO: they fix a bug where only the last > of any "-enable-kvm" and "-machine foo=bar" options have effect. > > Differences between Grant's v2 and this: > * use -machine options rather than a global > * patch 1/2 bug fixes > * some rearrangement/cleanup of arm_load_kernel() code > > Grant Likely (1): > arm: add device tree support > > Peter Maydell (3): > qemu-option: Add support for merged QemuOptsLists > Make -machine/-enable-kvm options merge into a single list > Make kernel, initrd and append be machine_opts > > Makefile.target | 1 + > configure | 1 + > hw/arm-misc.h | 1 + > hw/arm_boot.c | 96 > +++++++++++++++++++++++++++++++++++++++++++++++++++--- > qemu-config.c | 17 ++++++++++ > qemu-option.c | 7 +++- > qemu-option.h | 1 + > qemu-options.hx | 9 +++++ > vl.c | 35 ++++++++++++++------ > 9 files changed, 151 insertions(+), 17 deletions(-) > > -- > 1.7.5.4 > > >
