On 26/05/2023 15:37, Thomas Huth wrote: >On 26/05/2023 07.05, Jeuk Kim wrote: >> Universal Flash Storage (UFS) is a high-performance mass storage device >> with a serial interface. It is primarily used as a high-performance >> data storage device for embedded applications. >> >> This commit contains code for UFS device to be recognized >> as a UFS PCI device. >> Patches to handle UFS logical unit and Transfer Request will follow. >> >> Signed-off-by: Jeuk Kim <jeuk20....@samsung.com> >> --- >> MAINTAINERS | 6 + >> hw/Kconfig | 1 + >> hw/meson.build | 1 + >> hw/ufs/Kconfig | 4 + >> hw/ufs/meson.build | 1 + >> hw/ufs/trace-events | 33 + >> hw/ufs/trace.h | 1 + >> hw/ufs/ufs.c | 305 ++++++++++ >> hw/ufs/ufs.h | 42 ++ >> include/block/ufs.h | 1251 ++++++++++++++++++++++++++++++++++++++ >> include/hw/pci/pci.h | 1 + >> include/hw/pci/pci_ids.h | 1 + >> meson.build | 1 + > >Do you expect lots of additional files to be added to the hw/ufs/ folder? If >the answer is no, then it's maybe a little bit overkill to introduce a >separate folder for this. Wouldn't hw/block/ be a good fit for this as well? >Or maybe we could introduce hw/flash/ or so and also move the contents of >hw/nvme there?
Yes. I plan to add more files to UFS for different functions (UICCMD, MQ, zoned, etc.) like nvme. So personally, I think it would be good to keep the hw/ufs/ directory.
