On Fri, Jun 09, 2023 at 12:49:25AM +0200, Juan Quintela wrote:
Please explain why this is considered ok, given the comment about
why it is disabled. ie if we fixed something, refrence the commit.
> Signed-off-by: Juan Quintela <quint...@redhat.com>
> ---
> tests/qtest/migration-test.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 01ab51a391..9f86d9bc80 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -2886,14 +2886,8 @@ int main(int argc, char **argv)
> }
> qtest_add_func("/migration/multifd/tcp/plain/none",
> test_multifd_tcp_none);
> - /*
> - * This test is flaky and sometimes fails in CI and otherwise:
> - * don't run unless user opts in via environment variable.
> - */
> - if (getenv("QEMU_TEST_FLAKY_TESTS")) {
> - qtest_add_func("/migration/multifd/tcp/plain/cancel",
> - test_multifd_tcp_cancel);
> - }
> + qtest_add_func("/migration/multifd/tcp/plain/cancel",
> + test_multifd_tcp_cancel);
> qtest_add_func("/migration/multifd/tcp/plain/zlib",
> test_multifd_tcp_zlib);
> #ifdef CONFIG_ZSTD
> --
> 2.40.1
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
