-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 11.02.2012 14:07, schrieb Jan Kiszka: > On 2012-02-11 14:06, Andreas Färber wrote: >> Am 11.02.2012 13:43, schrieb Jan Kiszka: >>> On 2012-02-11 12:49, Andreas Färber wrote: >>>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>>> I think using cpu_single_env is an indication of a >>>>> problem, like poor code, layering violation or poor API >>>>> (vmport). What is your use case? >>>> >>>> I couldn't spot any in this series. Jan, note that any new >>>> use of env or cpu_single_env will need to be redone when we >>>> convert to QOM CPU. >> >>> cpu_single_env should have nothing to do with QOM. >> >> It does, cf. my patch series: Current CPU*State is being embedded >> in the QOM object and most future code outside TCG will use a
Let me stress this: >> CPU rather than CPUState pointer. >> The reason is that CPUState is totally target-specific and does >> not belong in common code. > > So are the devices that depend on a current CPU pointer. You will > have to provide something equivalent. CPU base class v3: http://patchwork.ozlabs.org/patch/139284/ (v4 coming up) That doesn't prevent target-specific devices. Although Paolo does want that to change wrt properties. Andreas - -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBAgAGBQJPNmtzAAoJEPou0S0+fgE/SRQP+gLK/FvwIOXZqvSn+i+ooxin jXOvH3oBtfiIQp5+59KGlOd7dSjILFwoPtH3U5tGDpI5HHLFpQQOsuppsiBwVOC9 9QUgqFt9d/xodvPJ0gv5ShghoEmCZNdFwNnBYeqB69mEDm5sZwYlvWgXaOgRti2+ 0lhGFVISetImmQbiy5l7ubMONwcGUCVuT7pjiZ+S/Cew7wvGW5O7fpo3P8b4Xw4E P7qX6y785Sm4Wn8iEangFOUqer5ALAS0fL2xHo5NYUUZ8jgn2xwDIT8TP9t8Pkei 5U0kWm+mNyvJ4VLxsN449LNGDV+c3AMyzPodRmV2KJBYISDRIFYlar/SkJGiBkvo cNKdJLrkm4KIEt6eomyhYgSHJi5nUeoT60lAaZkHIDNonKoFw8swhf85wSi7sQmq 38nIY+F5YAHZ3TQCfTfxTDHy2Wbc6G7bn792FWKOxCVLWtD2Bp3iQv8J3MlYEhMJ fnJv+/nKUQuPlti4LNwrhJyRLPUNrc6PKgzC8He4dupLMASFPuSMh4mKRlWj41+/ SYKvXz42elSqv2Z798eA8VNCbs7e+0EH67BJQLIL3QEuD4vY/Yfeulr3CGsfkLEL m+UIAAntzloSkZvxuKmI5MP5XrjHTAbWuab+Gh9kYVyEsWZj4TAvn1hobKtU7sv9 lMd32AbfCskRN8jAw8So =0Rvo -----END PGP SIGNATURE-----