On Tue, 6 Jun 2023 at 19:24, Marcin Juszkiewicz
<marcin.juszkiew...@linaro.org> wrote:
>
> From: Shashi Mallela <shashi.mall...@linaro.org>
>
> Included creation of ITS as part of SBSA platform GIC
> initialization.
>
> Signed-off-by: Shashi Mallela <shashi.mall...@linaro.org>
Marcin, this should have your signed-off-by too because
the patch came to us via you.
> +static void create_gic(SBSAMachineState *sms, MemoryRegion *mem)
> {
> unsigned int smp_cpus = MACHINE(sms)->smp.cpus;
> SysBusDevice *gicbusdev;
> @@ -436,6 +451,12 @@ static void create_gic(SBSAMachineState *sms)
> qdev_prop_set_uint32(sms->gic, "len-redist-region-count", 1);
> qdev_prop_set_uint32(sms->gic, "redist-region-count[0]", redist0_count);
>
> + if (!kvm_irqchip_in_kernel()) {
> + object_property_set_link(OBJECT(sms->gic), "sysmem",
> + OBJECT(mem), &error_fatal);
> + qdev_prop_set_bit(sms->gic, "has-lpi", true);
> + }
sbsa-ref never uses KVM, so we don't need the
kvm_irqchip_in_kernel() check, we can just always
set the link and the has-lpi prop.
Otherwise this looks OK.
thanks
-- PMM
