Re: [PATCH] hw/ppc/spapr: Test whether TCG is enabled with tcg_enabled()

[Harsh Prateek Bora]

On 6/20/23 13:18, Philippe Mathieu-Daudé wrote:

Although the PPC target only supports the TCG and KVM
accelerators, QEMU supports more. We can no assume that
'!kvm == tcg', so test for the correct accelerator. This
also eases code review, because here we don't care about
KVM, we really want to test for TCG.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  hw/ppc/spapr.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index dcb7f1c70a..c4b666587b 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2524,7 +2524,7 @@ static void spapr_set_vsmt_mode(SpaprMachineState *spapr, 
Error **errp)
      int ret;
      unsigned int smp_threads = ms->smp.threads;

- if (!kvm_enabled() && (smp_threads > 1)) {

+    if (tcg_enabled() && (smp_threads > 1)) {
          error_setg(errp, "TCG cannot support more than 1 thread/core "
                     "on a pseries machine");

Reviewed-by: Harsh Prateek Bora <hars...@linux.ibm.com>

          return;