On 6/19/23 17:42, Philippe Mathieu-Daudé wrote:
Keep the VFP helpers in the same file, guarding them with #ifdef'ry.

Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org>
---
  target/arm/tcg/helper-a64.c | 87 ----------------------------------
  target/arm/vfp_helper.c     | 93 ++++++++++++++++++++++++++++++++++++-
  2 files changed, 92 insertions(+), 88 deletions(-)

I'm not keen on this. First, because we have not yet disentangled vfp_helper.c from the bits required by KVM, so to move the rest into tcg/. Second because large ifdef blocks are a sign that something wants splitting anyway.

Perhaps tcg/vfp_a64_helper.c?  There's probably a better name we could use...


r~

Reply via email to