On Tue, 20 Jun 2023 at 17:28, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 6/20/23 17:57, Peter Maydell wrote: > > On Tue, 20 Jun 2023 at 13:46, Richard Henderson > > <richard.hender...@linaro.org> wrote: > >> > >> Changes for v5: > >> * Enabled only by cpu property x-rme=on, not -cpu max. > >> * Rebase vs SecEL2 fixes, now in master. > >> > >> This doesn't have the magic RMM memory, which previous patch sets > >> included for booting Huawei's forked TF-A. Upstream TF-A does not > >> have sufficient code to build either PLAT={qemu,qemu_sbsa} with > >> the RMM enabled, so that can't be tested either at the moment. > >> > >> All I can say is that this doesn't appear to break anything else > >> with x-rme=on. Which is less than satisfying. > > > > Have you tried 'make check-tcg' ? I get: > > > > make: Leaving directory > > '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang' > > make: Entering directory > > '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang' > > BUILD arm-softmmu guest-tests > > RUN arm-softmmu guest-tests > > TEST test-armv6m-undef on arm > > BUILD arm-linux-user guest-tests > > RUN arm-linux-user guest-tests > > TEST semihosting on arm > > SKIPPED semiconsole on arm because MANUAL ONLY > > TEST convd on arm > > DIFF float_convd.out with > > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/tests/tcg/arm/float_convd.ref > > TEST convs on arm > > DIFF float_convs.out with > > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/tests/tcg/arm/float_convs.ref > > TEST madds on arm > > DIFF float_madds.out with > > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/tests/tcg/arm/float_madds.ref > > TEST munmap-pthread on arm > > ** > > ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion > > failed: (success) > > make[1]: *** [Makefile:174: run-munmap-pthread] Error 124 > > make: *** > > [/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/tests/Makefile.include:56: > > run-tcg-tests-arm-linux-user] Error 2 > > make: Leaving directory > > '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang' > > > > But I haven't run 'check-tcg' recently, so maybe that's an > > existing bug rather than something in this series. > > Not today -- I only tried system mode because, obviously. :-) > Let me double-check...
I get the same error on current head-of-git, so whatever it is it's not this patchset's fault. thanks -- PMM