Hi Michael, On Fri, Jun 23, 2023 at 09:54:54AM +0300, Michael Tokarev wrote: > 22.06.2023 17:51, Bastian Koppelmann wrote: > .. > > > Is it a -stable material? > > > > Yes. If you pick this up, make sure you also pick up > > https://lore.kernel.org/qemu-devel/20230621161422.1652151-1-kbast...@mail.uni-paderborn.de/T/#md18391dd165c4fc2e60ddefb886f3522e715f487 > > which applies the same fix to other instructions. > > Aha. "Add CHECK_REG_PAIR() for insn accessing 64 bit regs". > This subject suggests the patch's adding this macro, instead > of using it. If it were worded like "Use CHECK.. for.." instead, I'd > notice this one too. > > Picked up both, thank you! > > Is there anything else in this series worth picking up for stable, eg: > > Fix helper_ret() not correctly restoring PSW > Fix RR_JLI clobbering reg A[11]
These are rare cases where the guest does something wrong. It will not lead to a crash of QEMU. > > or maybe others? > > Please, in the future, add Cc: qemu-sta...@nongnu.org for patches > worth to have in -stable. I will do that. I'm not sure what is worth while to pick up for stable. My initial thought was fixes for bugs that can lead to a crash in QEMU. Any pointer would make it easier for me to decide what to CC: qemu-sta...@nongnu.org for. Thanks, Bastian
