On Tue, 14 Feb 2012, Paul Brook wrote: > > Yes, you are right. Also considering that we are only calling > > slirp_update_timeout if CONFIG_SLIRP is defined, there is no need for > > the !CONFIG_SLIRP dummy version of the function. > > Looks reasonable to me. Unfortunately I can't remember which combination of > headless VM and timer configs caused hangs when this was originally added. > > If anyone has a setup that suffered timeout-related hangs last time we made > this change, please retest with this patch. Otherwise I guess we apply the > patch and hope we didn't miss anything.
OK, thanks. I'll resend the patch as part of the series and ask for testing. > > Author: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > > Date: Mon Feb 13 11:25:03 2012 +0000 > > > > main_loop_wait: block indefinitely > > > > - remove qemu_calculate_timeout; > > > > - explicitly size timeout to uint32_t; > > > > - introduce slirp_update_timeout; > > > > - pass NULL as timeout argument to select in case timeout is the > > maximum value; > > > > Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > > Acked-by: Paul Brook <p...@codesourcery.com> >
