On Tue, 2023-06-27 at 09:47 +0200, Thomas Huth wrote: > The stack array is only referenced from the start-up code (which is > shared between the s390-ccw.img and the s390-netboot.img), but it is > currently declared twice, once in main.c and once in netmain.c. > It makes more sense to declare this in start.S instead - which will > also be helpful in the next patch, since we need to mention the .bss > section in start.S in that patch. > > While we're at it, let's also drop the huge alignment of the stack, > since there is no technical requirement for aligning it to page > boundaries. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > pc-bios/s390-ccw/s390-ccw.h | 1 - > pc-bios/s390-ccw/main.c | 1 - > pc-bios/s390-ccw/netmain.c | 1 - > pc-bios/s390-ccw/start.S | 6 ++++++ > 4 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Eric Farman <far...@linux.ibm.com>
