On 29/06/2023 15.47, Philippe Mathieu-Daudé wrote:
Hi Thomas,
On 29/6/23 14:54, Thomas Huth wrote:
pci_nic_init_nofail() calls qemu_find_nic_model(), and this function
sets nd->model = g_strdup(default_model) if it has not been initialized
yet. So we don't have to set nd->model to the default_nic in the
calling sites.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/arm/sbsa-ref.c | 8 +-------
hw/arm/virt.c | 8 +-------
hw/loongarch/virt.c | 8 +-------
hw/mips/loongson3_virt.c | 8 +-------
hw/xtensa/virt.c | 8 +-------
5 files changed, 5 insertions(+), 35 deletions(-)
...
This remind me of a branch from end of April with this
unfinished patch, did we already discuss this together?
No, I haven't seen your patch yet, neither we talked about it. I came up
with the idea for my patch on my own after looking at certain spots in the
code. But I guess you could easily rebase your patch on top of mine in case
you want to finish it ;-)
Thomas
