On Thu, Jun 22, 2023 at 01:37:31PM -0700, Steve Sistare wrote: > +static int file_parse_offset(char *filespec, uint64_t *offsetp, Error **errp) > +{ > + char *option = strstr(filespec, OFFSET_OPTION); > + int ret; > + > + if (option) { > + *option = 0; > + option += sizeof(OFFSET_OPTION) - 1; > + ret = qemu_strtosz(option, NULL, offsetp); > + if (ret) { > + error_setg_errno(errp, ret, "file URI has bad offset %s", > option);
Probably "-ret" here. > + return -1; > + } > + } > + return 0; > +} -- Peter Xu