On Mon Jul 3, 2023 at 10:23 PM AEST, Daniel Henrique Barboza wrote: > Hi, > > I'm afraid this patch breaks two Gitlab runners in different manners. > > > - the 'tsan-build' runner: > > https://gitlab.com/danielhb/qemu/-/jobs/4583483251 > > [2170/3531] Compiling C object libqemu-ppc64-softmmu.fa.p/target_ppc > _translate.c.o > FAILED: libqemu-ppc64-softmmu.fa.p/target_ppc_translate.c.o > clang -m64 -mcx16 -Ilibqemu-ppc64-softmmu.fa.p -I. -I.. -Itarget/ppc > -I../target/ppc -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/pixman-1 > -I/usr/include/capstone -I/usr/include/spice-server -I/usr/include/spice-1 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -fcolor-diagnostics -Wall -Winvalid-pch -Werror -std=gnu11 -O2 -g > -fsanitize=thread -fstack-protector-strong -Wundef -Wwrite-strings > -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls > -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k > -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels > -Wexpansion-to-defined -Wmissing-format-attribute -Wno-initializer-overrides > -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-string-plus-int > -Wno-typedef-redefinition -Wno-tautological-type-limit-compare -Wno-psabi > -Wno-gnu-variable-sized-type-not-at-end -Wthread-safety -isystem > /builds/danielhb/qemu/linux-headers -isystem linux-headers -iquote . -iquote > /builds/danielhb/qemu -iquote /builds/danielhb/qemu/include -iquote > /builds/danielhb/qemu/host/include/x86_64 -iquote > /builds/danielhb/qemu/host/include/generic -iquote > /builds/danielhb/qemu/tcg/i386 -pthread -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common -fwrapv -fPIE > -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H > '-DCONFIG_TARGET="ppc64-softmmu-config-target.h"' > '-DCONFIG_DEVICES="ppc64-softmmu-config-devices.h"' -MD -MQ > libqemu-ppc64-softmmu.fa.p/target_ppc_translate.c.o -MF > libqemu-ppc64-softmmu.fa.p/target_ppc_translate.c.o.d -o > libqemu-ppc64-softmmu.fa.p/target_ppc_translate.c.o -c > ../target/ppc/translate.c > ../target/ppc/translate.c:249:20: error: unused function 'gen_serialize_core' > [-Werror,-Wunused-function] > static inline bool gen_serialize_core(DisasContext *ctx) > ^ > 1 error generated. > > And in fact, after this patch, gen_serialize_core() is now unused:
Sorry Daniel :( I keep losing my test config. I'll have to set up something a bit more permanent and reliable. Will resubmit. Thanks, Nick
