On Fri, 9 Jun 2023 at 18:23, Aaron Lindsay <aa...@os.amperecomputing.com> wrote: > > Changes from v2 of this patchset [0]: > - Remove properties for EPAC, Pauth2, FPAC, FPACCombined > - Separate out aa64isar2 addition into its own patch > - Comment clarifications > - Several code formatting/simplifications > - Rebase on top of latest upstream changes (for example, those which > reorganized decoding PAC branch instructions) > > [0] - https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg06494.html
I was looking at trying to bring this into target-arm.next, since the changes in patches 1 and 2 for code review comments are not large. However I found that it fails "make check": ERROR:../../tests/qtest/arm-cpu-features.c:425:pauth_tests_default: assertion failed: (g_str_equal(_error, "cannot enable pauth-impdef without pauth")) as a result of patch 8's changes to the handling of the CPU pauth related properties. The assertion seems to be because patch 8 has changed the error string to something different from that which the test case is looking for. Patch 8 needs to also update the test case to include testing of the handling of the new properties it adds. thanks -- PMM
