On Fri, 7 Jul 2023 at 05:04, Cédric Le Goater <c...@kaod.org> wrote:
> pnv_quad_realize realizes power9 and power10 quad objects but ... > > > } > > > > static Property pnv_quad_properties[] = { > > @@ -528,6 +581,9 @@ static void pnv_quad_power10_class_init(ObjectClass > > *oc, void *data) > > > > pqc->xscom_ops = &pnv_quad_power10_xscom_ops; > > pqc->xscom_size = PNV10_XSCOM_EQ_SIZE; > > + > > + pqc->xscom_qme_ops = &pnv_qme_power10_xscom_ops; > > + pqc->xscom_qme_size = PNV10_XSCOM_QME_SIZE; > > xscom_qme_size is only defined on power10 and it is 0 on power9. The region > is nevertheless initialized on power9 and never mapped. > > I think we should introduce a specific realize routine for each proc now. I overlooked the P9 behaviour, thanks for pointing that out. I'll make the realise proc specific. Cheers, Joel