On Fri, Jul 7, 2023 at 1:34 PM Philippe Mathieu-Daudé <phi...@linaro.org>
wrote:

> On 7/7/23 11:22, Konstantin Kostiuk wrote:
> > Signed-off-by: Konstantin Kostiuk <kkost...@redhat.com>
> > ---
> >   qga/vss-win32/install.cpp   | 12 ++++++------
> >   qga/vss-win32/requester.cpp |  9 +++++----
> >   2 files changed, 11 insertions(+), 10 deletions(-)
>
>
> > @@ -304,9 +305,8 @@ STDAPI COMRegister(void)
> >       }
> >       strcpy(tlbPath, dllPath);
> >       strcpy(tlbPath+n-3, "tlb");
> > -    fprintf(stderr, "Registering " QGA_PROVIDER_NAME ":\n");
> > -    fprintf(stderr, "  %s\n", dllPath);
> > -    fprintf(stderr, "  %s\n", tlbPath);
> > +    qga_debug("Registering " QGA_PROVIDER_NAME ": %s %s",
> > +              dllPath, tlbPath);
>
> Previous has 3 "\n", not necessary? Otherwise:
>

I think 3 "\n" is not necessary. The line is still human-readable.


>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
>
> >       if (!PathFileExists(tlbPath)) {
> >           hr = HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND);
> >           errmsg(hr, "Failed to lookup tlb");
>
>
>

Reply via email to