On 7/6/23 21:40, John Allen wrote:
case 0x80000007: *eax = 0; - *ebx = 0; + *ebx = env->features[FEAT_8000_0007_EBX] | CPUID_8000_0007_EBX_SUCCOR; *ecx = 0; *edx = env->features[FEAT_8000_0007_EDX]; break;
I agree that it needs no hypervisor support, but Babu is right that you cannot add it unconditionally (especially not on Intel processors).
You can special case CPUID_8000_0007_EBX_SUCCOR in kvm_arch_get_supported_cpuid() so that it is added even on old kernels. There are already several such cases. Adding it to KVM is nice to have anyway, so please send a patch for that.
Also, the patch does not compile (probably you missed a prerequisite) as it lacks all the rigamarole that is needed to add FEAT_8000_0007_EBX.
Paolo