On 7/3/23 23:33, Ruibo Lu wrote:
the check of top PMP is redundant and will not influence the return value, so consider remove it Reviewed-by: Weiwei Li <liwei...@iscas.ac.cn> Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Signed-off-by: Ruibo Lu <reape...@hust.edu.cn> ---
I believe we might want to add: Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1733
target/riscv/pmp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index 9d8db493e6..1a9279ba88 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -49,11 +49,6 @@ static inline int pmp_is_locked(CPURISCVState *env, uint32_t pmp_index) return 1; }- /* Top PMP has no 'next' to check */- if ((pmp_index + 1u) >= MAX_RISCV_PMPS) { - return 0; - } - return 0; }
