Like we did for the QMP socket, use socketpair() for the console socket so that hopefully there isn't a race condition during early boot where data might get dropped on the floor.
May or may not help with various race conditions where early console output is not showing up in the logs and/or potentially being missed by wait_for_console_pattern. V2: - Fixed some Socket ownership/garbage collection problems - Fixed callers of now-dropped VM arguments/properties - added a dedicated sock_fd arg to ConsoleSocket() - now using socketpair() for qtest console, too. - dropped sock_dir arg from *all* machine.py classes - Tested quite a bit more thoroughly ... CI: https://gitlab.com/jsnow/qemu/-/pipelines/945067498 John Snow (6): python/machine: move socket setup out of _base_args property python/machine: close sock_pair in cleanup path python/console_socket: accept existing FD in initializer python/machine: use socketpair() for console connections python/machine: use socketpair() for qtest connection python/machine: remove unused sock_dir argument python/qemu/machine/console_socket.py | 29 ++++++++--- python/qemu/machine/machine.py | 58 +++++++++++++--------- python/qemu/machine/qtest.py | 54 +++++++++++++++----- tests/avocado/acpi-bits.py | 5 +- tests/avocado/avocado_qemu/__init__.py | 2 +- tests/avocado/machine_aspeed.py | 5 +- tests/qemu-iotests/iotests.py | 2 +- tests/qemu-iotests/tests/copy-before-write | 3 +- 8 files changed, 104 insertions(+), 54 deletions(-) -- 2.41.0
