On 7/31/23 18:47, Helge Deller wrote:
On 7/31/23 12:23, Akihiko Odaki wrote:
On 2023/07/31 19:17, Joel Stanley wrote:
On Mon, 31 Jul 2023 at 09:31, Michael Tokarev <m...@tls.msk.ru> wrote:
31.07.2023 11:03, Akihiko Odaki wrote:
linux-user was failing on M2 MacBook Air. Digging into the details, I found
several bugs in brk and mmap so here are fixes.
There's another work in this area by Helge Deller, have you seen it?
("linux-user: Fix and optimize target memory layout", a v5 already).
Applying this series fixes the qemu-arm running the static armhf
binary on my ppc64le host that I reported here[1].
>> [1]
https://lore.kernel.org/qemu-devel/CACPK8XeyqcEDyyL3Jw2WYWs_gGdtTCf2=ly04cmgkshsmdj...@mail.gmail.com/
Tested-by: Joel Stanley <j...@jms.id.au>
Thanks for testing.
The changes conflict with Helge's patches, so it would be good to work
out which of your changes should be combined with his.
I suggest Helge to rebase his change to my series. The below is some
detailed explanation:
It is almost orthogonal to my series, but patch 2 will conflict with
my series since it changes how the initial brk is calculated.
Unfortunately I think patch 2 has a bug. Without my patch, do_brk()
assumes the heap is aligned with the host page size, but the patch
does not consider the case that the host and target page sizes are
different.
I've included your patches #2 (bugfix) and #3 (cleanup) to my latest
patch series and published it at
https://github.com/hdeller/qemu-hppa/tree/brk-fixes-akihiko
Maybe you and Joel could try it out?
I re-read the thread again. As it seems Joel already tried the latest
version from me? Sadly I can't test myself on ppc64le (static binary
needs klibc-PupSAGgtpafMlSLXOLgje1kXFo8.so in /usr/lib which I can't
install on a debian porterbox).
I still believe we need to track host and target brk page, but I'll give
your patch a try.
Helge
