> Good catch.  Mostly ok.

Thanks much for looking at this.

> No need for inline markers.

Thanks.

> In general it is bad form to call HELPER(foo) directly.  In this case
> it doesn't hurt, but better form to reverse the implementations.

Good point. I had copied this from the arm vfp code which flipped the
order. I've flipped those around.

> What's missing is an update to vmstate, to make sure all the architectural 
> bits are 
> properly saved. Add

Yup, thanks. I've sent another version of the patch along.

-- 
-keith

Attachment: signature.asc
Description: PGP signature

Reply via email to