On Wed, 26 Jul 2023 at 15:00, Sergey Kambalin <serg.o...@gmail.com> wrote: > > Signed-off-by: Sergey Kambalin <sergey.kamba...@auriga.com> > --- > hw/gpio/bcm2838_gpio.c | 52 +++++++++++++++++++++++++++++++++- > include/hw/gpio/bcm2838_gpio.h | 6 ++++ > 2 files changed, 57 insertions(+), 1 deletion(-)
Looking at the last three patches, the code for this device seems very very similar to the existing bcm2835_gpio device. What exactly are the differences? It looks like maybe just the number of powerup/down registers -- could we share the same device model and give it a new property for "number of PUP_PDN regs" to avoid duplicating 300+ lines of code ? Or are there other differences I've missed? thanks -- PMM
