On 02/19/12 22:28, Alon Levy wrote: > Add an implementation of the DisplayAllocator callbacks for qxl. Uses > the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 > bits per pixel line convertion. Since free/resize/create are defined in > qxl.c, it is easy to ensure consistent usage of the flag (it means > QXL_ALLOCATED basically). > > With this patch and the previous two screendump works for vga and qxl > modes when using qxl and spice together. This might break sdl/vnc with > spice, untested since it isn't of known use.
Breaking vnc+spice being used in parallel breaking is exactly what I suspect might be possible. IIRC there where discussions about just enabling both vnc+spice, then let users pick what to use, so I'd prefer to not break this. Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too. cheers, Gerd
