On Mon, 7 Aug 2023 22:31:35 +0800 Zhao Liu <zhao1....@linux.intel.com> wrote:
> Hi Igor, > > On Mon, Aug 07, 2023 at 12:11:29PM +0200, Igor Mammedov wrote: > > Date: Mon, 7 Aug 2023 12:11:29 +0200 > > From: Igor Mammedov <imamm...@redhat.com> > > Subject: Re: [PATCH v2 2/3] hw/smbios: Fix thread count in type4 > > X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) > > > > On Mon, 7 Aug 2023 13:06:47 +0300 > > Michael Tokarev <m...@tls.msk.ru> wrote: > > > > > 07.08.2023 12:56, Igor Mammedov wrote: > > > > On Sat, 5 Aug 2023 09:00:41 +0300 > > > > Michael Tokarev <m...@tls.msk.ru> wrote: > > [...] > > > The whole thing - provided the preparational patch a1d027be95 > > > "machine: Add helpers to get cores/threads per socket" is also > > > picked up - applies cleanly and in a stright-forward way to 8.0 > > > and even to 7.2, and passes the usual qemu testsuite. Sure thing > > > since the issues weren't noticed before, the testsuite does not > > > cover this area. It'd be nice to have some verifier to check if > > > the whole thing actually works after applying the patchset. > > > > Zhao Liu, > > can you help us out with adding test cases to cover the code > > you are touching? > > Yes, sure. > > Just double check, I should add these 2 test cases: > 1. in "bios-tables-test.c" to test smbios type4 topology related things, and > 2. also in "test-smp-parse.c" to test our new topology helpers. > > Do I understand correctly? yep, I'd do both. Also looking at test cases I don't see any test cases that check topo end-to-end path (at least for x86). I mean checking related CPUID values. One possible place to it without writing testcase from scratch could be test-x86-cpuid-compat.c. Where I'd add test cases for some CPUID leaves at certain topo configurations (values to check could be hardcoded magic numbers as long as they are properly documented/reference specs) . > > -Zhao > > > > > [...] > > >
