Hi, >>> @@ -151,6 +171,7 @@ void qxl_render_update(PCIQXLDevice *qxl) >> >> dpy_update() call here. Calling that one isn't safe without grabbing >> the qemu lock. > > About dpy_update, discovered it the hard way. You mean I need the lock > for dpy_update or also before?
Any qemu code should be considered thread-unsafe unless proven otherwise. On a quick scan I havn't noticed anything but the dpy_update() call. It makes sense to wrap the whole loop though, so you grab the lock only once. cheers, Gerd
