Re: [PATCH] linux-user/riscv: Use abi_ulong for target_ucontext

[Philippe Mathieu-Daudé]

On 8/8/23 11:34, LIU Zhiwei wrote:

We should not use types dependend on host arch for target_ucontext.
This bug is found when run rv32 applications.

Signed-off-by: LIU Zhiwei <zhiwei_...@linux.alibaba.com>
---
  linux-user/riscv/signal.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/linux-user/riscv/signal.c b/linux-user/riscv/signal.c
index eaa168199a..ff8634a272 100644
--- a/linux-user/riscv/signal.c
+++ b/linux-user/riscv/signal.c
@@ -38,8 +38,8 @@ struct target_sigcontext {
  }; /* cf. riscv-linux:arch/riscv/include/uapi/asm/ptrace.h */

struct target_ucontext {

-    unsigned long uc_flags;
-    struct target_ucontext *uc_link;
+    abi_ulong uc_flags;

Correct.

+    abi_ulong uc_link;

Isn't it 'abi_ptr uc_link' instead?

      target_stack_t uc_stack;
      target_sigset_t uc_sigmask;
      uint8_t   __unused[1024 / 8 - sizeof(target_sigset_t)];