Am 20.02.2012 15:04, schrieb Anthony Liguori: >> * Half of the menu entries appears to be translated by the libraries >> used. Give me something that is all German or something that is all >> English. Mixed languages looks unprofessional. > > This is because of the use of stock items. I can overload the labels and > force > english menu names. I can also add some basic internationalization and make > greater use of stock item names. > > I would actually prefer the later approach although practically speaking, the > monitor would remain in English. Would this seem awkward? > > What's preferable for non-native English speakers?
If we get a clean and logical separation (e.g. all the menu items are translated and all the output in the monitor is English), I think that would be fine. >> * Ctrl-Alt-= as shortcut for Zoom In isn't easy to remember and only >> makes some sense on a US keyboard layout. > > There doesn't appear to be a stock accelerator for Zoom in GTK. Firefox > advertises Ctrl-+ as the zoom in accelerator but apparently accepts Ctrl-+ or > Ctrl-=. > > I'd be happy with just doing Ctrl-Alt-+. It's a little more awkward to type > but > that seems to be the standard. That would be better. We could still accept Ctrl-Alt-= additionally like you describe for Firefox. >> * The window has a button for maximising, but it doesn't really do >> anything. > > This is your Window Manager. We call gtk_window_set_resizable(False) and > that > should cause the maximize button to disappear. Indeed, if you look at the > screenshots I posted, there isn't a maximize button. Just checked again and it doesn't seem to be there. I almost thought I had been dreaming when I wrote this, but in fact switching to fullscreen and back gives me the button. Can you reproduce it this way? (But I won't run more tests while writing an email, the OOM killer always kills Thunderbird first... Means that the bug is reproducible at least.) >> * Ctrl-PgDn/PgUp does change the tab as I expected on VGA, it's ignored >> by the monitor and the serial0 tabs. > > This is something that probably needs some work. Right now we propagate all > key > presses which is what allows the accelerators to work. What we probably > should > do is check the key presses against only the accelerators we want to work and > propagate those. > > This is a bit tricky though. The end effect would be that Ctrl-PgDn would > stop > working on the VGA tab. I think this is expected behavior. Yes, I think this is fine. And in this case it would also be fine if it didn't work in other tabs. Consistency is probably most important here. Kevin