On Wed, 16 Aug 2023 at 10:16, Thomas Huth <th...@redhat.com> wrote: > > Update the berkeley-testfloat-3 wrap to include a patch provided by > Olaf Hering. This fixes a problem with "control reaches end of non-void > function [-Werror=return-type]" compiler warning/errors that are now > enabled by default in certain versions of GCC. > > Reported-by: Olaf Hering <o...@aepfle.de> > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > subprojects/berkeley-testfloat-3.wrap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
This seems like a reasonable place to ask: should we just pull in the testfloat and softfloat repos to be part of the main qemu repo? AIUI we've definitively forked both of these, so we don't care about trying to make it easy to resync with upstream. Having them in separate git repos seems to have some clear disadvantages: * it's harder to update them * changes to them can end up skipping the usual code review process, because it's a different patch flow to the normal one * we get extra meson subproject infrastructure to deal with Are there any reasons to keep them separate ? thanks -- PMM
