On 8/17/23 08:50, Peter Maydell wrote:
+ if (arg_is_const(op->args[1]) + && arg_info(op->args[1])->val == 0 + && op->args[3] == 0) { + uint64_t mask = MAKE_64BIT_MASK(0, op->args[4]);The docs for the TCG deposit op don't say what the restrictions on the immediate args are, but this will be UB for QEMU if args[4] is 0. Have we already sanitized those somewhere?
tcg_gen_deposit_{i32,i64} do so. r~