Re: [PATCH 14/22] Implement msync(2)

[Richard Henderson]

On 8/19/23 02:47, Karim Taha wrote:
+static inline abi_long do_bsd_msync(abi_long addr, abi_long len, abi_long 
flags)
+{
+    if (!access_ok(VERIFY_WRITE, addr, len)) {

I think this check is wrong.  There's nothing in the kernel that requires writability, or 
even that the entire range be mapped.

I think you want guest_range_valid_untagged to simply check that the bounds are 
ok.

With that,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>



r~