On Thu, Aug 17, 2023 at 02:50:10PM +0200, Kevin Wolf wrote: > In previous patches, we changed some transactionable functions to be > marked as GRAPH_WRLOCK, but required that tran_finalize() is still > called without the lock. This was because all callbacks that can be in > the same transaction need to follow the same convention. > > Now that we don't have conflicting requirements any more, we can switch > all of the transaction callbacks to be declared GRAPH_WRLOCK, too, and > call tran_finalize() with the lock held. > > Document for each of these transactionable functions that the lock needs > to be held when completing the transaction, and make sure that all > callers down to the place where the transaction is finalised actually > have the writer lock. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 61 +++++++++++++++++++++++++++++++++++++++++---------------- > 1 file changed, 44 insertions(+), 17 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
