On Wed, Aug 23, 2023 at 09:53:35AM +0300, Michael Tokarev wrote:
> Signed-off-by: Michael Tokarev <m...@tls.msk.ru>
> ---
>  accel/tcg/tb-maint.c       | 2 +-
>  backends/tpm/tpm_ioctl.h   | 2 +-
>  chardev/char-socket.c      | 6 +++---
>  chardev/char.c             | 2 +-
>  contrib/plugins/cache.c    | 2 +-
>  contrib/plugins/lockstep.c | 2 +-
>  crypto/afalg.c             | 2 +-
>  crypto/block-luks.c        | 6 +++---
>  crypto/der.c               | 2 +-
>  crypto/der.h               | 6 +++---
>  linux-user/flatload.c      | 2 +-
>  linux-user/syscall.c       | 4 ++--
>  nbd/client-connection.c    | 2 +-
>  net/checksum.c             | 4 ++--
>  net/filter.c               | 4 ++--
>  net/vhost-vdpa.c           | 8 ++++----
>  semihosting/config.c       | 2 +-
>  semihosting/syscalls.c     | 4 ++--
>  softmmu/icount.c           | 2 +-
>  softmmu/ioport.c           | 2 +-
>  20 files changed, 33 insertions(+), 33 deletions(-)

Wide-ranging; but since the nbd/ change caught my eye (rather, my mail
filters), I went ahead and reviewed the entire patch.

> +++ b/crypto/block-luks.c

> @@ -424,5 +424,5 @@ qcrypto_block_luks_store_header(QCryptoBlock *block,
>  
>  /*
> - * Loads the main LUKS header,and byteswaps it to native endianess
> + * Loads the main LUKS header,and byteswaps it to native endianness

While touching this line,

s/header,and/header, and/

> +++ b/net/filter.c
> @@ -93,5 +93,5 @@ ssize_t qemu_netfilter_pass_to_next(NetClientState *sender,
>          /*
>           * if qemu_netfilter_pass_to_next been called, means that
> -         * the packet has been hold by filter and has already retured size
> +         * the packet has been hold by filter and has already returned size

More than just a typo in this sentence.  Maybe:

If qemu_netfilter_pass_to_next has been called, it means that the
packet was held by a filter and has already returned size...

>           * to the sender, so sent_cb shouldn't be called later, just
>           * pass NULL to next.

With those tweaks,

Reviewed-by: Eric Blake <ebl...@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org


Reply via email to